Zack's Kernel News
The New "No New Warnings" Warning
Recently, Linus threw all the kernel developers into a jar and shook the jar really hard by making all compiler warnings into errors by default. This broke everything for light years in all directions and resulted in much wailing and unhappy bioluminescent patterns.
Now things have returned pretty much to normal, but developers are each finding their own ways to deal with the new "no warnings" policy. For example, Paolo Bonzini submitted some KVM patches from a variety of other contributors, one of which was described in the patch comment as, "avoid warning with -Wbitwise-instead-of-logical."
Linus prepared to put Paulo back in the jar, saying:
"Christ. Please no.
"Guys, you can't just mindlessly shut off warnings without even thinking about the code.
"Apparently the compiler gives completely insane warning 'fixes' suggestions, and somebody just completely mindlessly followed that compiler badness.
"The way to do a logical 'or' (instead of a bitwise one on two boolean expressions) is to use '||'.
"Instead, the code was changed to completely insane
(int) boolexpr1 | (int) boolexpr2
"thing, which is entirely illegible and pointless, and no sane person should ever write code like that.
"In other words, the *proper* fix to a warning is to look at the code, and *understand* the code and the warning, instead of some mindless conversion to just avoid a warning.
"NEVER EVER do mindless changes to source code because the compiler tells you to. Apparently the clang people wrote a particularly bad warning 'explanation', and that's on clang.
"I'm not going to pull this. The clang warning fix is wrong, and then another commit literally disables accounting for another non-fatal run-time warning.
"Again – warnings are not an excuse to just 'mindlessly shut up the warning'.
"They need some thought.
"None of this kind of 'I'll do wrong things just to make the warning go away' garbage that this pull request has two very different examples of.
"I'm adding some clang people, because apparently that
note: cast one or both operands to int to silence this warning
"thing came from clang. Somebody in the clang community really needs to re-think their 'informational' messages.
"Giving people those kinds of insane suggestions is a disservice to everybody. Clang should fix their stupid 'note' before release. Please, guys."
And that was that.
« Previous 1 2
Buy this article as PDF
(incl. VAT)
Buy Linux Magazine
Subscribe to our Linux Newsletters
Find Linux and Open Source Jobs
Subscribe to our ADMIN Newsletters
Support Our Work
Linux Magazine content is made possible with support from readers like you. Please consider contributing when you’ve found an article to be beneficial.
News
-
So Long Neofetch and Thanks for the Info
Today is a day that every Linux user who enjoys bragging about their system(s) will mourn, as Neofetch has come to an end.
-
Ubuntu 24.04 Comes with a “Flaw"
If you're thinking you might want to upgrade from your current Ubuntu release to the latest, there's something you might want to consider before doing so.
-
Canonical Releases Ubuntu 24.04
After a brief pause because of the XZ vulnerability, Ubuntu 24.04 is now available for install.
-
Linux Servers Targeted by Akira Ransomware
A group of bad actors who have already extorted $42 million have their sights set on the Linux platform.
-
TUXEDO Computers Unveils Linux Laptop Featuring AMD Ryzen CPU
This latest release is the first laptop to include the new CPU from Ryzen and Linux preinstalled.
-
XZ Gets the All-Clear
The back door xz vulnerability has been officially reverted for Fedora 40 and versions 38 and 39 were never affected.
-
Canonical Collaborates with Qualcomm on New Venture
This new joint effort is geared toward bringing Ubuntu and Ubuntu Core to Qualcomm-powered devices.
-
Kodi 21.0 Open-Source Entertainment Hub Released
After a year of development, the award-winning Kodi cross-platform, media center software is now available with many new additions and improvements.
-
Linux Usage Increases in Two Key Areas
If market share is your thing, you'll be happy to know that Linux is on the rise in two areas that, if they keep climbing, could have serious meaning for Linux's future.
-
Vulnerability Discovered in xz Libraries
An urgent alert for Fedora 40 has been posted and users should pay attention.